FLUENT_PACKAGE_SERVICE_RESTART: make empty or other values as auto #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be easy to understand to be the default value if users don't set FLUENT_PACKAGE_SERVICE_RESTART explicitly. Signed-off-by: Daijiro Fukuda <[email protected]>
|
We can simplify the specification by this. * `manual`:
* If the service was active before update, the service does not restart automatically. The old processes continue to work after update.
* You need to restart service manually as follows:
* [The zero downtime restart](https://github.com/fluent/fluentd/pull/4624): Send `SIGUSR2` to the supervisor process.
* Normal restart: Restart service normally, such as `systemctl restart`.
* Please use this when you want to manage plugins manually, or the environment is offline.
- * Note: it is considered as `manual` for any value other than `auto`, such as an empty value.
- Caution: if you have already customized the file, this value becomes an empty value and is considered as `manual` because the file is not updated. |
Merged
kenhys
pushed a commit
that referenced
this pull request
Dec 11, 2024
) Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
pushed a commit
that referenced
this pull request
Dec 11, 2024
) Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be easy to understand to be the default value if users don't set FLUENT_PACKAGE_SERVICE_RESTART explicitly.